feat: moving cache sync timeout to controller level #1576
Conversation
| @@ -133,4 +135,8 @@ public Stream<R> list(Predicate<R> predicate) { | |||
| return cache.list(predicate); | |||
| } | |||
|
|
|||
| public void setControllerConfiguration(ControllerConfiguration<P> controllerConfiguration) { | |||
There was a problem hiding this comment.
This PR is missing some tests because if you remove this method, everything still builds fine and yet, the controllerConfiguration is not properly initialized. And actually, this method is never called anywhere in the code.
There was a problem hiding this comment.
uhh, good catch, forgot t remove that, before it was used.
There was a problem hiding this comment.
removed.
(The InformerRelatedBehaviorITS would fail if this would not work)
There was a problem hiding this comment.
Still not working right, though, because now the controllerConfiguration is never set… So why even record it and pass it to initSources?
There was a problem hiding this comment.
ahh yes, now that part is also cleaned up :)
this makes sense if there are multiple controlelrs, where this value might vary
csviri
force-pushed
the
sync-timeout-controller
branch
from
669679d to
e85f572
Compare
|
Kudos, SonarCloud Quality Gate passed! |
this makes sense if there are multiple controlelrs, where this value might vary